[k8sattributesprocessor] Fall back to only container in pod in case no container name/id has been specified in the incoming resource attributes #36844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicitly Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
ChrsMark,
dmitryax,
fatsheep9146 and
TylerHelmuth
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
| @@ -227,7 +227,19 @@ func (kp *kubernetesprocessor) addContainerAttributes(attrs pcommon.Map, pod *ku | |||
| return | |||
| } | |||
| default: | |||
| return | |||
| switch { | |||
There was a problem hiding this comment.
I think we can just add those two cases just parallel to the cases outside, no need to be nested into a default case, which is clearer?
Signed-off-by: Florian Bacher <[email protected]>
ChrsMark
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a fallback logic to the processor by adding the container attributes for an incoming resource without the container name/id being explicitly set, provided the related pod only contains one container. If there are more than one container in a pod, the container name/id still have to be set explicitly.
Link to tracking issue
Fixes #34189
Testing
Added unit tests
Documentation
Adapted the readme to reflect the changes made in this PR