[exporter/doris] Send json lines to doris rather than json array #36912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker-star-l
changed the title
atoulme
reviewed
Dec 20, 2024
atoulme
approved these changes
Dec 20, 2024
|
@atoulme Is there any problem with this pr? |
|
Hi @atoulme , is this pr ready to merge? |
atoulme
added
the
ready to merge
|
sure is. Marked ready to merge. |
TylerHelmuth
approved these changes
Jan 13, 2025
Merged
codeboten
pushed a commit
that referenced
this pull request
Jan 14, 2025
Fix lint issue caused by #36912 This reverts commit 778d8f7. @adrielp @niwoerner I can't explain why, but it seems that after #36838 the extension integration tests never complete. You can see in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test.yml?query=branch%3Amain that we haven't got an integration test suite to pass since merging the new receiver. Reverting to unblock CI.
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…n-telemetry#36912) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Send json lines to doris rather than json array. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36896 <!--Describe what testing was performed and which tests were added.--> #### Testing unit test <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
Fix lint issue caused by open-telemetry#36912 This reverts commit open-telemetry@778d8f7. @adrielp @niwoerner I can't explain why, but it seems that after open-telemetry#36838 the extension integration tests never complete. You can see in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test.yml?query=branch%3Amain that we haven't got an integration test suite to pass since merging the new receiver. Reverting to unblock CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send json lines to doris rather than json array.
Link to tracking issue
Fixes #36896
Testing
unit test
Documentation