Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two new metrics for vcenter receiver #37253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

samiura
Copy link

@samiura samiura commented Jan 15, 2025

Description

This PR adds the vcenter.vm.memory.granted and vcenter.host.cpu.capacity metric.
More information on this metric can be found here.

#37257

Testing

The metric was scraped from a test vCenter environment, and golden test files were updated to reflect the addition of the metric.

Documentation

Documentation was updated according to the metadata.yaml

Screenshot 2025-01-14 at 10 48 02 AM Screenshot 2025-01-15 at 11 35 31 AM

@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch from 3f669bc to a848f1d Compare January 15, 2025 19:22
@samiura samiura marked this pull request as ready for review January 15, 2025 19:51
@samiura samiura requested a review from a team as a code owner January 15, 2025 19:51
@samiura samiura requested a review from ChrsMark January 15, 2025 19:51
@samiura
Copy link
Author

samiura commented Jan 15, 2025

Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement.

@schmikei
Copy link
Contributor

schmikei commented Jan 15, 2025

Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement.

I think it would be good to create an issue so that it can be triaged before accepted. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7fd70545b1ca223f8e1b21e9d45cb1d1df3a6e36/issue-triaging.md

Let me know if you need help creating the issue, but I would describe this as a good issue to emulate. It helps keep the changelog clean and gives people a place to triage/discuss the feature!

#33607

@samiura
Copy link
Author

samiura commented Jan 15, 2025

Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement.

I think it would be good to create an issue so that it can be triaged before accepted. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7fd70545b1ca223f8e1b21e9d45cb1d1df3a6e36/issue-triaging.md

Let me know if you need help creating the issue, but I would describe this as a good issue to emulate. It helps keep the changelog clean and gives people a place to triage/discuss the feature!

#33607

@schmikei Created #37257

@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch 2 times, most recently from 53bf317 to dc605a5 Compare January 15, 2025 22:49
@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch 6 times, most recently from b04fe58 to 5e081d1 Compare January 16, 2025 21:02
@samiura samiura force-pushed the add-two-new-vecenter-receiver-metrics branch from 5e081d1 to 185c3fe Compare January 17, 2025 01:18
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Codeowners should review.

@samiura
Copy link
Author

samiura commented Jan 17, 2025

Changes look good to me. Codeowners should review.

Thanks @atoulme

Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a codeowner this looks good to me, thank you for your contribution 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants