-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two new metrics for vcenter receiver #37253
base: main
Are you sure you want to change the base?
Added two new metrics for vcenter receiver #37253
Conversation
3f669bc
to
a848f1d
Compare
Do I need to create an issue for this? Per this link, it does not seem like one is warranted for this particular enhancement. |
I think it would be good to create an issue so that it can be triaged before accepted. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7fd70545b1ca223f8e1b21e9d45cb1d1df3a6e36/issue-triaging.md Let me know if you need help creating the issue, but I would describe this as a good issue to emulate. It helps keep the changelog clean and gives people a place to triage/discuss the feature! |
|
53bf317
to
dc605a5
Compare
b04fe58
to
5e081d1
Compare
Signed-off-by: Samiur Arif <[email protected]>
5e081d1
to
185c3fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Codeowners should review.
Co-authored-by: Antoine Toulme <[email protected]>
Thanks @atoulme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a codeowner this looks good to me, thank you for your contribution 🚀
Description
This PR adds the vcenter.vm.memory.granted and vcenter.host.cpu.capacity metric.
More information on this metric can be found here.
#37257
Testing
The metric was scraped from a test vCenter environment, and golden test files were updated to reflect the addition of the metric.
Documentation
Documentation was updated according to the metadata.yaml