[internal/filter] Add filterottl functions with additional options #37271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
changed the title
TylerHelmuth
approved these changes
Jan 16, 2025
TylerHelmuth
added
the
Skip Changelog
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…pen-telemetry#37271) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The `transformprocessor` is currently using the `internal/filter/filterottl` to create `conditions` expressions. In order to support path's with context prefix, it needs to configure the underline `ottl.Parser` using their `EnablePathContextNames` options. This PR changes this internal API adding new functions that accepts the parsers options as argument. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to open-telemetry#29017 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
transformprocessoris currently using theinternal/filter/filterottlto createconditionsexpressions. In order to support path's with context prefix, it needs to configure the underlineottl.Parserusing theirEnablePathContextNamesoptions. This PR changes this internal API adding new functions that accepts the parsers options as argument.Link to tracking issue
Related to #29017
Testing
Unit tests