fix(telemetrygen): startTimestamp when temporality is cumulative #39022
+99
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAnge
force-pushed
the
nickange/telemetrygen/metrics/fix-timestamp-cumulative-temporality
branch
from
a938cf1 to
e98cf1c
Compare
atoulme
reviewed
Mar 27, 2025
atoulme
reviewed
Mar 27, 2025
|
This looks like a good fix. I have fixed up the imports. Would you please add a changelog entry using |
codeboten
reviewed
Mar 27, 2025
There was a problem hiding this comment.
Thanks @NickAnge! Please add changelog as mentioned by @atoulme, here's the details https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry
NickAnge
changed the title
…cumulative-temporality
|
Thanks for the review @atoulme and @codeboten . I have added the changelog. Let me know if you have any feedback |
|
hmm, I am not sure why the tests are failing to be honest 🤔 I run the action locally and also tests and they succeed. Could be transient ? Can we re-trigger the action ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #38232
Testing
Locally Testing with a collector + logs
Cumulative - default
Delta