Skip to content

Commit

Permalink
[chore] refactor(contrib): remove unused replace directive for `go-co…
Browse files Browse the repository at this point in the history
…nnections` package (#677)

The package `github.com/docker/go-connections` only exists in contrib's generated `go.mod` file
in version `v0.5.0`, and does not exist in the replaced version `v0.4.1`.
The distro also builds and runs fine without the replace directive.

I believe the [reason](open-telemetry/opentelemetry-collector-contrib#12322 (comment))
for the replace directive to have been added is out of date.
To be sure, I have run the repro scenario described [here](docker/go-connections#99 (comment))
and the behavior with go-connections v0.5.0 was correct - the Docker client tried to connect to the TCP port.

Co-authored-by: Alex Boten <[email protected]>
  • Loading branch information
andrzej-stencel and codeboten authored Oct 2, 2024
1 parent 545bd7c commit edc8e94
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions distributions/otelcol-contrib/manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ providers:

# When adding a replace, add a comment before it to document why it's needed and when it can be removed
replaces:
# See https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/12322#issuecomment-1185029670
- github.com/docker/go-connections v0.4.1-0.20210727194412-58542c764a11 => github.com/docker/go-connections v0.4.0
# see https://github.com/mattn/go-ieproxy/issues/45
- github.com/mattn/go-ieproxy => github.com/mattn/go-ieproxy v0.0.1
# see https://github.com/openshift/api/pull/1515
Expand Down

0 comments on commit edc8e94

Please sign in to comment.