Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][mdatagen]: fix unused and missing imports #11821

Closed
wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

Description

fix unused and missing imports in mdatagen

Link to tracking issue

Related to open-telemetry/opentelemetry-collector-contrib#36511

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 8, 2024 11:04
@mmorel-35 mmorel-35 requested a review from djaglowski December 8, 2024 11:04
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (3f3e208) to head (def3920).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11821   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         445      445           
  Lines       23737    23737           
=======================================
  Hits        21739    21739           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 changed the title [mdatagen]: fix unused and missing imports [chore][mdatagen]: fix unused and missing imports Dec 8, 2024
@mmorel-35
Copy link
Contributor Author

/cc @bogdandrutu

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 9, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same as #11762 ?

@mmorel-35
Copy link
Contributor Author

Indeed !

@mmorel-35 mmorel-35 closed this Dec 9, 2024
@mmorel-35 mmorel-35 deleted the mdatagen-fix branch December 9, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants