Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/mdatagen] Remove level field from metrics #12145

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 21, 2025

Description

Removes level field. This will be added back in the future once #11754 is completed.

Link to tracking issue

Updates #11061

@mx-psi mx-psi force-pushed the mx-psi/deprecate-level-mdatagen branch from 3dbab92 to fbe6e42 Compare January 21, 2025 12:45
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (70f9fe9) to head (89296a4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12145   +/-   ##
=======================================
  Coverage   91.74%   91.75%           
=======================================
  Files         463      462    -1     
  Lines       24931    24885   -46     
=======================================
- Hits        22873    22833   -40     
+ Misses       1674     1668    -6     
  Partials      384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi marked this pull request as ready for review January 22, 2025 10:27
@mx-psi mx-psi requested review from bogdandrutu, dmitryax and a team as code owners January 22, 2025 10:27
@mx-psi mx-psi added this pull request to the merge queue Jan 22, 2025
Merged via the queue into open-telemetry:main with commit b844bb7 Jan 22, 2025
53 checks passed
@mx-psi mx-psi deleted the mx-psi/deprecate-level-mdatagen branch January 22, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants