Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[exporter][queuebatcher] set feature gate UsePullingBasedExporterQueueBatcher to beta" #12246

Merged
merged 1 commit into from
Feb 2, 2025
+1 −34
Merged

Revert "[exporter][queuebatcher] set feature gate UsePullingBasedExporterQueueBatcher to beta" #12246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .chloggen/set-new-queue-batching-to-beta.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion exporter/exporterhelper/internal/base_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (

var usePullingBasedExporterQueueBatcher = featuregate.GlobalRegistry().MustRegister(
"exporter.UsePullingBasedExporterQueueBatcher",
featuregate.StageBeta,
featuregate.StageAlpha,
featuregate.WithRegisterFromVersion("v0.115.0"),
featuregate.WithRegisterDescription("if set to true, turns on the pulling-based exporter queue bathcer"),
)
Expand Down
8 changes: 0 additions & 8 deletions exporter/exporterhelper/internal/batch_sender_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,14 +374,6 @@ func TestBatchSender_ConcurrencyLimitReached(t *testing.T) {
expectedItems: 51,
},
}

// Why do we not expect the same behavior when usePullingBasedExporterQueueBatcher is true?
// This test checks that when concurrency limit of batch_sender is reached, the batch_sender will flush immediately.
// To avoid blocking, the concurrency limit is set to the number of concurrent goroutines that are in charge of
// reading from the queue and adding to batch. With the new model, we are pulling instead of pushing so we don't
// block the reading goroutine anymore.
defer setFeatureGateForTest(t, usePullingBasedExporterQueueBatcher, false)()

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
qCfg := exporterqueue.NewDefaultConfig()
Expand Down
Loading