Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Prepare release v1.25.0/v0.119.0 #12252

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

opentelemetrybot
Copy link
Contributor

The following commands were run to prepare this release:

  • make chlog-update VERSION=v1.25.0/v0.119.0
  • make prepare-release PREVIOUS_VERSION=1[.]24[.]0 RELEASE_CANDIDATE=1.25.0 MODSET=stable
  • make prepare-release PREVIOUS_VERSION=0[.]118[.]0 RELEASE_CANDIDATE=0.119.0 MODSET=beta

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (643a35f) to head (d541220).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12252   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         465      465           
  Lines       25658    25658           
=======================================
  Hits        23426    23426           
  Misses       1816     1816           
  Partials      416      416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Feb 3, 2025

@codeboten I noticed something weird. I was double checking that the metrics::level still works after the move to views with this config:

receivers:
  otlp:
    protocols:
      grpc:
        endpoint: localhost:5317
      http:
        endpoint: localhost:5318

exporters:
  debug:
    verbosity: detailed

service:
  telemetry:
    metrics:
      level: detailed
      readers:
        - periodic:
            interval: 10000
            exporter:
              otlp:
                protocol: http/protobuf
                endpoint: localhost:4318
  pipelines:
    metrics:
      receivers: [otlp]
      exporters: [debug]

With this config, if I wait a few seconds, I get this error message (no need to send any telemetry):

2025/02/03 10:13:45 failed to upload metrics: Post "https:///v1/metrics": http: no Host in request URL

It sounds like the service::telemetry::metrics::readers[0]::periodic::exporter::otlp::endpoint is being ignored/set to empty? The error went away with a build of 2447a81885fc580860860bd6a8768422a70c99f8, I have not bisected but it feels related to your change to update the config dependency. Could you take a look at this before we do the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants