Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentations] Use IConfiguration for semantic conventions compatibility check #4627

Merged
merged 8 commits into from
Jul 6, 2023
Merged

[Instrumentations] Use IConfiguration for semantic conventions compatibility check #4627

merged 8 commits into from
Jul 6, 2023

Conversation

vishweshbankwar
Copy link
Member

Towards #4537 (comment)

@vishweshbankwar vishweshbankwar changed the title [Instrumentation.AspNetCore] Use IConfiguration for semantic conventions compatibility check [Instrumentations] Use IConfiguration for semantic conventions compatibility check Jun 29, 2023
Vishwesh Bankwar added 2 commits June 29, 2023 17:04
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #4627 (9664712) into main (104cf32) will decrease coverage by 0.03%.
The diff coverage is 93.68%.

❗ Current head 9664712 differs from pull request most recent head 8c7b7e2. Consider uploading reports for the commit 8c7b7e2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4627      +/-   ##
==========================================
- Coverage   84.90%   84.88%   -0.03%     
==========================================
  Files         313      314       +1     
  Lines       12609    12667      +58     
==========================================
+ Hits        10706    10752      +46     
- Misses       1903     1915      +12
Impacted Files Coverage Δ
...ent/Implementation/GrpcClientDiagnosticListener.cs 86.66% <ø> (-0.22%) ⬇️
...ient/Implementation/SqlClientDiagnosticListener.cs 85.00% <ø> (-0.19%) ⬇️
...NetCore/AspNetCoreMetricsInstrumentationOptions.cs 71.42% <60.00%> (-28.58%) ⬇️
....GrpcNetClient/GrpcClientInstrumentationOptions.cs 75.00% <60.00%> (-25.00%) ⬇️
...ion.Http/HttpClientMetricInstrumentationOptions.cs 60.00% <60.00%> (ø)
...ion.AspNetCore/AspNetCoreInstrumentationOptions.cs 100.00% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 90.27% <100.00%> (-0.06%) ⬇️
...AspNetCore/Implementation/HttpInMetricsListener.cs 63.26% <100.00%> (-0.74%) ⬇️
...ation.AspNetCore/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...tion.AspNetCore/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 10 more

... and 3 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review June 30, 2023 22:21
@vishweshbankwar vishweshbankwar requested a review from a team June 30, 2023 22:21
CodeBlanch
CodeBlanch approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utpilla
utpilla reviewed Jul 6, 2023
View reviewed changes
OpenTelemetry.sln Outdated Show resolved Hide resolved
@utpilla utpilla merged commit 56fdb16 into open-telemetry:main Jul 6, 2023
@TimothyMothra
Copy link
Contributor

#4484

utpilla pushed a commit that referenced this pull request Jul 7, 2023
@vishweshbankwar
Follow up from #4627 (#4645)
ad08228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@utpilla utpilla utpilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishweshbankwar @TimothyMothra @CodeBlanch @utpilla