-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpSemanticConventions - new metric in HttpClient Instrumentation #4891
HttpSemanticConventions - new metric in HttpClient Instrumentation #4891
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4891 +/- ##
==========================================
+ Coverage 82.88% 83.27% +0.39%
==========================================
Files 294 294
Lines 12200 12211 +11
==========================================
+ Hits 10112 10169 +57
+ Misses 2088 2042 -46
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@TimothyMothra I think there's too much duplication of code going on in these tests. I tried to clean it up on #4870. Can you help me get that PR reviewed & merged and then can we apply this on top of that? |
I'll take a look at the other PR today. I was about to pull some of the test changes out of THIS PR and create a smaller test refactor PR. I'll review your changes before I go down this path :) |
Converting this to Draft. I think #4870 is going to merge first. If there are too many merge conflicts, it might easier to recreate this PR. |
Towards #4484
This PR adds the new
http.client.request.duration
metrics in the HttpClient Instrumentation library.Changes
OTEL_SEMCONV_STABILITY_OPT_IN
http.client.duration
(milliseconds) replaced withhttp.client.request.duration
(seconds)This is defined in the as-of-yet unreleased v1.22.0 https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md
HttpClientTests
renamed toHttpClientTests.Old
. new classesHttpClientTests.New
andHttpClientTests.Dupe
.This covers all options of the environment variable.
http-out-test-cases.json
renamed tohttp-out-test-cases_Old.json. new files
http-out-test-cases_New.jsonand
http-out-test-cases_Dupe.json`These files hold all test cases for the previous test classes.
HttpClientTests.Basic
was updated to accommodate 3 json files.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes