Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Document links maybe added after Activity creation #5972

Merged
merged 4 commits into from
Nov 13, 2024
Merged

[docs] Document links maybe added after Activity creation #5972

merged 4 commits into from
Nov 13, 2024

Conversation

cijothomas
Copy link
Member

Fixes #5273

Apart from API Doc, a simple test also added!

@cijothomas cijothomas requested a review from a team as a code owner November 12, 2024 22:12
@github-actions github-actions bot added pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package documentation Documentation related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Nov 12, 2024
@cijothomas cijothomas mentioned this pull request Nov 12, 2024
Merged
reyang
reyang approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although my approval probably won't count.

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (6250307) to head (7d2f234).
Report is 389 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5972      +/-   ##
==========================================
+ Coverage   83.38%   86.21%   +2.83%     
==========================================
  Files         297      262      -35     
  Lines       12531    11906     -625     
==========================================
- Hits        10449    10265     -184     
+ Misses       2082     1641     -441
Flag Coverage Δ
unittests ?
unittests-Project-Stable 86.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 250 files with indirect coverage changes

@CodeBlanch CodeBlanch changed the title Modify readme to indicate links maybe added after Activity creation [docs] Document links maybe added after Activity creation Nov 13, 2024
@CodeBlanch CodeBlanch merged commit 74fc70e into open-telemetry:main Nov 13, 2024
33 checks passed
@cijothomas cijothomas deleted the cijothomas/addlinks branch November 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@Kielek Kielek Kielek approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
documentation Documentation related pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add links after activity (span) creation
5 participants
@cijothomas @Kielek @rajkumar-rangaraj @reyang @CodeBlanch