Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded eqwalizer_rebar3 plugin #813

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

tsloughter
Copy link
Member

Oops forgot to send this fix for #810

@tsloughter tsloughter requested a review from a team as a code owner December 29, 2024 10:17
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.32%. Comparing base (a8dd294) to head (c04020e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   17.32%   17.32%           
=======================================
  Files          24       24           
  Lines         710      710           
=======================================
  Hits          123      123           
  Misses        587      587           
Flag Coverage Δ
api 17.32% <ø> (ø)
elixir 17.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryannaegele
Copy link
Contributor

@tsloughter do you know where meck is getting pulled in? Seems like some dep needs to have a version set.
image

@tsloughter
Copy link
Member Author

Hm, I'll check. But what did we decide on version support? is it current + 2 or current + 3? If its current + 2 then 24 wouldn't be supported anyway and can be dropped from CI.

@tsloughter
Copy link
Member Author

Its a top level dep that I for some reason did {deps, [{meck, ">= 0.0.0"}]}...

@bryannaegele
Copy link
Contributor

Good point.

@bryannaegele
Copy link
Contributor

#814

@bryannaegele bryannaegele merged commit 4818920 into open-telemetry:main Jan 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants