Improve contributor guide #687
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 52.49% 52.49%
=======================================
Files 57 57
Lines 3444 3444
=======================================
Hits 1808 1808
Misses 1466 1466
Partials 170 170 ☔ View full report in Codecov by Sentry. |
RichardChukwu
changed the title
RichardChukwu
changed the title
| New contributors are welcome! | ||
|
|
||
| ## Pre-requisites | ||
| * Go (version required) TBD |
There was a problem hiding this comment.
Not sure it is stated anywhere in the repo though, if its the latest version, I think it would be helpful to include it, as some versions may cause conflicts especially for first time contributors
There was a problem hiding this comment.
There was a problem hiding this comment.
ooh, didn't see this, I think it will be useful to add this info to the contributing guide or at least link to this file?
There was a problem hiding this comment.
This PR does not improve anything. It lacks details in all points.
What is more, the nice welcoming message was even removed from unknown reason: #687 (review)
I appreciate your will to contribute. However, please "do your homework" before submitting a PR.
Duly noted @pellared I'll review accordingly and get required info before submitting a PR, I apologize for the lack of details |
part of open-telemetry/sig-contributor-experience#31
Changes
This will make it clearer for first time contributors to ensure they have all they require to contribute locally without running into issues.
Please review and let me know if you have any suggestions or feedback.