Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding instrumentation support for mongo-driver/v2 #6539
base: main
Are you sure you want to change the base?
feat: adding instrumentation support for mongo-driver/v2 #6539
Changes from 2 commits
95dcf65
24b5f1e
b3cbb84
a0f083b
f83a9ab
8e90ad0
9590887
71da688
6d22da1
37c8729
4e44c3e
f6ec856
d38d115
0403896
e97fcde
bd3c9c5
407eea4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this to note that the code was copied from a specific instance of the v1 instrumentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to reference the commit version that it was based on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a new package, we should rely on the latest semantic conventions (1.30.0) right away, let's not make things harder by forcing a migration right away :)
Check warning on line 74 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L73-L74
Check warning on line 90 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L89-L90
Check warning on line 94 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L93-L94
Check warning on line 114 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L113-L114
Check warning on line 122 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L122
Check warning on line 144 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L143-L144
Check warning on line 147 in instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go#L146-L147