Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semconv package for otelrestful #6710

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Feb 4, 2025

This switches otelrestful to use the semconv internal package, so it can migrate to stable HTTP semconv attributes.

Closes #6639

@github-actions github-actions bot requested a review from dashpole February 4, 2025 10:27
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 87.78338% with 97 lines in your changes missing coverage. Please review.

Project coverage is 75.1%. Comparing base (d21dd87) to head (c711f43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...o-restful/otelrestful/internal/semconv/httpconv.go 86.0% 42 Missing and 15 partials ⚠️
...go-restful/otelrestful/internal/semconv/v1.20.0.go 89.9% 11 Missing and 7 partials ⚠️
...lei/go-restful/otelrestful/internal/semconv/env.go 89.1% 15 Missing and 1 partial ⚠️
...ei/go-restful/otelrestful/internal/semconv/util.go 89.4% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6710     +/-   ##
=======================================
+ Coverage   74.5%   75.1%   +0.5%     
=======================================
  Files        199     203      +4     
  Lines      17529   18322    +793     
=======================================
+ Hits       13075   13771    +696     
- Misses      4070    4142     +72     
- Partials     384     409     +25     
Files with missing lines Coverage Δ
...hub.com/emicklei/go-restful/otelrestful/restful.go 100.0% <100.0%> (ø)
...ei/go-restful/otelrestful/internal/semconv/util.go 89.4% <89.4%> (ø)
...lei/go-restful/otelrestful/internal/semconv/env.go 89.1% <89.1%> (ø)
...go-restful/otelrestful/internal/semconv/v1.20.0.go 89.9% <89.9%> (ø)
...o-restful/otelrestful/internal/semconv/httpconv.go 86.0% <86.0%> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu marked this pull request as ready for review February 4, 2025 10:39
@dmathieu dmathieu requested a review from a team as a code owner February 4, 2025 10:39
@MrAlias MrAlias added this to the v1.35.0 milestone Feb 6, 2025
@dmathieu dmathieu merged commit 39ffca8 into open-telemetry:main Feb 7, 2025
26 checks passed
@dmathieu dmathieu deleted the semconv-otelrestful branch February 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Migrate to semconv for otelrestful
3 participants