Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/golangci/golangci-lint to v1.64.2 #6758

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 12, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/golangci/golangci-lint v1.63.4 -> v1.64.2 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

golangci/golangci-lint (github.com/golangci/golangci-lint)

v1.64.2

Compare Source

v1.64.1

Compare Source

v1.64.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Feb 12, 2025
@renovate renovate bot requested a review from a team as a code owner February 12, 2025 01:07
Copy link
Contributor Author

renovate bot commented Feb 12, 2025

ℹ Artifact update notice

File name: tools/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 9 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.22.9 -> 1.24.0
github.com/Crocmagnon/fatcontext v0.6.0 -> v0.7.1
github.com/ghostiam/protogetter v0.3.8 -> v0.3.9
github.com/golangci/gofmt v0.0.0-20241223200906-057b0627d9b9 -> v0.0.0-20250106114630-d62b90e6713d
github.com/golangci/revgrep v0.5.3 -> v0.8.0
github.com/ldez/gomoddirectives v0.6.0 -> v0.6.1
github.com/ldez/grignotin v0.8.0 -> v0.9.0
github.com/matoous/godox v0.0.0-20241202171805-94d1edd68ebb -> v1.1.0
github.com/mgechev/revive v1.5.1 -> v1.6.0
honnef.co/go/tools v0.5.1 -> v0.6.0

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1%. Comparing base (bf12f32) to head (a6269ee).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6758   +/-   ##
=====================================
  Coverage   75.1%   75.1%           
=====================================
  Files        203     203           
  Lines      18323   18323           
=====================================
+ Hits       13769   13775    +6     
+ Misses      4144    4140    -4     
+ Partials     410     408    -2     
Files with missing lines Coverage Δ
.../aws/aws-lambda-go/otellambda/wrapLambdaHandler.go 91.9% <100.0%> (ø)

... and 1 file with indirect coverage changes

tools/go.mod Outdated Show resolved Hide resolved
Copy link
Contributor Author

renovate bot commented Feb 12, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions github-actions bot requested a review from akats7 February 12, 2025 09:15
@@ -63,7 +63,7 @@ func validateReturns(handler reflect.Type) error {
}

// Wraps and calls customer lambda handler then unpacks response as necessary.
func (whf *wrappedHandlerFunction) wrapperInternals(ctx context.Context, handlerFunc interface{}, eventJSON []byte, event reflect.Value, takesContext bool) (interface{}, error) {
func (whf *wrappedHandlerFunction) wrapperInternals(ctx context.Context, handlerFunc interface{}, eventJSON []byte, event reflect.Value, takesContext bool) (interface{}, error) { // nolint:revive // this control flag is required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lint issue is surprising, and maybe a false positive?

flag-parameter: parameter 'len' seems to be a control flag, avoid control coupling

There is no len parameter though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like already fixed but not released: mgechev/revive#1211

@dmathieu
Copy link
Member

cc @open-telemetry/go-approvers since I had to add a commit.

@dmathieu dmathieu merged commit f10053e into main Feb 12, 2025
26 checks passed
@dmathieu dmathieu deleted the renovate/github.com-golangci-golangci-lint-1.x branch February 12, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants