[chore] Fix codecov action usage #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
force-pushed
the
fix-codecov
branch
from
7d94a6f
to
fdd3a95
Compare
pellared
requested review from
MrAlias,
XSAM,
dashpole and
dmathieu
as code owners
This was referenced Nov 14, 2024
|
After merging we should leave a comment under open-telemetry/community#2440 (comment) to notify if everything also works fine when the action runs on |
dmathieu
approved these changes
Nov 15, 2024
|
Merging as a trivial change that is supposed to fix the CI. |
pellared
added a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
Nov 15, 2024
Same as open-telemetry/opentelemetry-go#5979. This change makes sure that an unsuccessful upload will fail the workflow as this does not happen at the moment. Additionally, it configures the codecov action to be tokenless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that an unsuccessful upload will fail the workflow as this does not happen at the moment. See: https://github.com/open-telemetry/opentelemetry-go/actions/runs/11845773487/job/33011997881?pr=5978#step:3:175
Additionally, it configures the codecov action to be tokenless.
Related issue (most likely solved):
From https://github.com/codecov/codecov-action?tab=readme-ov-file#migration-guide:
More codecov/codecov-action#1645
v4 was still working. See: https://github.com/open-telemetry/opentelemetry-go/actions/runs/11842872629/job/33002565858#step:3:11
We might also consider reverting to v4 of the codecov action and just setting
fail_ci_if_error: true.