-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test helper for auto configure #6496
base: main
Are you sure you want to change the base?
Conversation
zeitlinger
commented
Jun 4, 2024
•
edited
Loading
edited
- it uses optional dependencies
- awaitility only for traces can probably be improved
- no tests yet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6496 +/- ##
============================================
- Coverage 90.62% 90.38% -0.24%
+ Complexity 6243 6233 -10
============================================
Files 683 682 -1
Lines 18701 18715 +14
Branches 1842 1845 +3
============================================
- Hits 16948 16916 -32
- Misses 1197 1242 +45
- Partials 556 557 +1 ☔ View full report in Codecov by Sentry. |
Would you be willing to present this at the Java SIG? It's not clear to me what the goal of this is and I think a synchronous conversation could help clear it up 🙂. Alternatively, a more detailed description could clarify the intent. |
yes, let's do that |
@zeitlinger per our conversation, see this link for an example of how we setup OTLP receivers in tests and make assertions against the payloads: https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/src/testFullConfig/java/io/opentelemetry/sdk/autoconfigure/FullConfigTest.java |