Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-knex): Use newer semantic conventions #2671

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

deejay1
Copy link
Contributor

@deejay1 deejay1 commented Jan 20, 2025

Which problem is this PR solving?

  • Updates deprecated attributes with current ones and drop deprecated function

Short description of the changes

  • Uses newer semantic conventions and replaces deprecated SpanAttributes call with Attributes
  • Syncs attributes with PostgreSQL instrumentation

@deejay1 deejay1 requested a review from a team as a code owner January 20, 2025 11:36
@github-actions github-actions bot added pkg:instrumentation-knex pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jan 20, 2025
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@deejay1 deejay1 force-pushed the knex-semantic-conventions branch from 7b91bdc to 3a70ffe Compare February 9, 2025 12:40
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (25b38f3) to head (5184085).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   89.20%   89.19%   -0.01%     
==========================================
  Files         168      169       +1     
  Lines        8076     8083       +7     
  Branches     1547     1547              
==========================================
+ Hits         7204     7210       +6     
- Misses        872      873       +1     
Files with missing lines Coverage Δ
...emetry-instrumentation-knex/src/instrumentation.ts 98.75% <100.00%> (+0.01%) ⬆️
.../opentelemetry-instrumentation-knex/src/semconv.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm trentm added the has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions label Mar 24, 2025
@trentm
Copy link
Contributor

trentm commented Mar 24, 2025

I'll sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-knex pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants