-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Contributing guide #1501
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
- Link relevant issues in the PR description. | ||
|
||
|
||
## Local Run/Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
I did my first work on this repo a few days ago, and the makefile doesn't work straight after a clone because of this line
include .env
I see what it does now, but some guidance on how to provision one would have been helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to set up .env
is at the very top of DEVELOPMENT.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh bloody hell. I did look for something like development.md
, totally missed the link in the main readme and then wondered why contributing.md was so slim. My fault 🤠
A lot of this seems to be duplicate info from DEVELOPMENT.md - I don't mind which is the source of truth, but I would prefer there was just one version of the truth. Since you're aligning multiple SIGs contribution guides, maybe removing double-ups from development guide? |
About this, I asked during SIG call attended and the idea was, having information that is relevant to a contributor not a user in the contributing guide was necessary, and apparently most of that info is already in the development guide. Maybe it can be removed from the development guide instead? |
I think so - both DEVELOPMENT and CONTRIBUTING seem to serve the same purpose, so how about CONTRIBUTING completely replaces DEVELOPMENT, and remove the latter? |
That can work, so are you removing it? |
This is your PR, you're doing it :) |
The CONTRIBUTING file already has major info from the DEVELOPMENT to create this PR though, so would it be better to just take current info as is and edit into the DEVELOPMENT guide and rename? |
I think that's the same thing. End result: DEVELOPMENT no longer exists, CONTRIBUTING contains all useful info from DEVELOPMENT and is in the format you want. |
This PR is part of Add Contributing guide to repos
This update aims to make it easier for contributors to get started with the project and follow best practices while contributing while following a consistent pattern for a setup guide across the Otel ecosystem.
Certain info was taken from the DEVELOPMENT.md guide to create this
Please review and let me know if you have any suggestions or feedback.