Add todos for error.type

open-telemetry · Jan 22, 2025 · 28d6ffd · 28d6ffd
1 parent 043b47f
commit 28d6ffd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...pentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py b/...pentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py
@@ -115,6 +115,8 @@ def traced_method(
             #             message_to_event(message, capture_content)
             #         )
 
+            # TODO: set error.type attribute
+            # https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-spans.md
             result = wrapped(*args, **kwargs)
             # TODO: handle streaming
             # if is_streaming(kwargs):

diff --git a/instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/test_chat_completions.py b/instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/test_chat_completions.py
@@ -164,6 +164,10 @@ def test_generate_content_extra_params(span_exporter, instrument_no_content):
 def assert_span_error(span: ReadableSpan) -> None:
     # Sets error status
     assert span.status.status_code == StatusCode.ERROR
+
+    # TODO: check thate error.type is set
+    # https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-spans.md
+
     # Records exception event
     error_events = [e for e in span.events if e.name == "exception"]
     assert error_events != []