urllib: don't assume we control the bucket metrics data point get in (#…

…3341) Instead of expecting an entry in a specific bucket, just sum all of them and assert we have the correct number of entries. Co-authored-by: Shalev Roda <[email protected]>
open-telemetry · Mar 6, 2025 · c0132c6 · c0132c6
1 parent 6572081
commit c0132c6
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py b/instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py
@@ -414,16 +414,16 @@ def test_metric_uninstrument(self):
             ) = metrics[:3]
 
             self.assertEqual(
-                client_duration.data.data_points[0].bucket_counts[1],
+                sum(client_duration.data.data_points[0].bucket_counts),
                 1,
             )
 
             self.assertEqual(
-                client_request_size.data.data_points[0].bucket_counts[0],
+                sum(client_request_size.data.data_points[0].bucket_counts),
                 1,
             )
             self.assertEqual(
-                client_response_size.data.data_points[0].bucket_counts[2],
+                sum(client_response_size.data.data_points[0].bucket_counts),
                 1,
             )
 
@@ -439,15 +439,15 @@ def test_metric_uninstrument(self):
             ) = metrics[:3]
 
             self.assertEqual(
-                client_duration.data.data_points[0].bucket_counts[1],
+                sum(client_duration.data.data_points[0].bucket_counts),
                 2,
             )
             self.assertEqual(
-                client_request_size.data.data_points[0].bucket_counts[0],
+                sum(client_request_size.data.data_points[0].bucket_counts),
                 2,
             )
             self.assertEqual(
-                client_response_size.data.data_points[0].bucket_counts[2],
+                sum(client_response_size.data.data_points[0].bucket_counts),
                 2,
             )
 
@@ -467,15 +467,15 @@ def test_metric_uninstrument(self):
             self.assertEqual(len(metrics), 3)
 
             self.assertEqual(
-                client_duration.data.data_points[0].bucket_counts[1],
+                sum(client_duration.data.data_points[0].bucket_counts),
                 2,
             )
             self.assertEqual(
-                client_request_size.data.data_points[0].bucket_counts[0],
+                sum(client_request_size.data.data_points[0].bucket_counts),
                 2,
             )
 
             self.assertEqual(
-                client_response_size.data.data_points[0].bucket_counts[2],
+                sum(client_response_size.data.data_points[0].bucket_counts),
                 2,
             )