Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: note to discourage additional contributions that pertain to old HTTP semantic conventions #2765

Merged
merged 7 commits into from
Aug 1, 2024
Merged

CONTRIBUTING: note to discourage additional contributions that pertain to old HTTP semantic conventions #2765

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c23131
Update CONTRIBUTING.md
emdneto Jul 31, 2024
79222e3
Update CONTRIBUTING.md
emdneto Jul 31, 2024
318e75d
Update CONTRIBUTING.md
emdneto Aug 1, 2024
0169c0f
Update CONTRIBUTING.md
emdneto Aug 1, 2024
7c33014
Update CONTRIBUTING.md
emdneto Aug 1, 2024
71903ac
Update CONTRIBUTING.md
emdneto Aug 1, 2024
a99dddb
Merge branch 'main' into emdneto-patch-2
lzchen Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ Below is a checklist of things to be mindful of when implementing a new instrume

- Follow semantic conventions
- The instrumentation should follow the semantic conventions defined [here](https://github.com/open-telemetry/semantic-conventions/tree/main/docs)
- To ensure quality and consistency, we seek to avoid supporting multiple outdated versions of HTTP semantic conventions. Contributions related to outdated HTTP semantic conventions will likely be discouraged, as they increase complexity and the potential for misconceptions. However, we are still open to considering exceptional cases where changes are well justified.
xrmx marked this conversation as resolved.
Show resolved Hide resolved
- Contains a name that is not already claimed in [Pypi](https://pypi.org/). Contact a maintainer, bring the issue up in the weekly Python SIG or create a ticket in Pypi if a desired name has already been taken.
- Extends from [BaseInstrumentor](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/2518a4ac07cb62ad6587dd8f6cbb5f8663a7e179/opentelemetry-instrumentation/src/opentelemetry/instrumentation/instrumentor.py#L35)
- Supports auto-instrumentation
Expand Down