Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-bootstrap: remove aws-lambda from default instrumentations #2786

Merged
merged 5 commits into from
Aug 12, 2024
Merged

opentelemetry-bootstrap: remove aws-lambda from default instrumentations #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76d5231
remove aws-lambda from default instrumentation in opentelemetry-boots…
emdneto Aug 8, 2024
378b306
fix changelog
emdneto Aug 8, 2024
6ad412c
fix script
emdneto Aug 8, 2024
f0b9493
Merge branch 'main' into remove-aws-lambda-default-instrumentation
emdneto Aug 12, 2024
cab212f
add comment explaining why removing aws-lambda
emdneto Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- `opentelemetry-instrumentation-kafka-python` Instrument temporary fork, kafka-python-ng
inside kafka-python's instrumentation
([#2537](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537)))
([#2537](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537))

## Breaking changes

- `opentelemetry-bootstrap` Remove `opentelemetry-instrumentation-aws-lambda` from the defaults instrumentations
([#2786](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2786))

## Fixed

- `opentelemetry-instrumentation-fastapi` fix `fastapi` auto-instrumentation by removing `fastapi-slim` support, `fastapi-slim` itself is discontinued from maintainers
Expand Down
1 change: 0 additions & 1 deletion opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@
]
default_instrumentations = [
"opentelemetry-instrumentation-asyncio==0.48b0.dev",
"opentelemetry-instrumentation-aws-lambda==0.48b0.dev",
"opentelemetry-instrumentation-dbapi==0.48b0.dev",
"opentelemetry-instrumentation-logging==0.48b0.dev",
"opentelemetry-instrumentation-sqlite3==0.48b0.dev",
Expand Down
9 changes: 9 additions & 0 deletions scripts/generate_instrumentation_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,21 @@
"bootstrap_gen.py",
)

# AWS Lambda instrumentation is excluded from the default list because it often
# requires specific configurations and dependencies that may not be set up
# in all environments. Instead, users who need AWS Lambda support can opt-in
# by manually adding it to their environment.
# See https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2787
packages_to_exclude = ["opentelemetry-instrumentation-aws-lambda"]


def main():
# pylint: disable=no-member
default_instrumentations = ast.List(elts=[])
libraries = ast.List(elts=[])
for pkg in get_instrumentation_packages():
if pkg.get("name") in packages_to_exclude:
continue
if not pkg["instruments"]:
default_instrumentations.elts.append(ast.Str(pkg["requirement"]))
for target_pkg in pkg["instruments"]:
Expand Down