-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mysql-connector instrumentor support for sqlcommenting #3163
Open
tammy-baylis-swi
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
tammy-baylis-swi:mysqlconnector-sqlcomment-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add mysql-connector instrumentor support for sqlcommenting #3163
tammy-baylis-swi
wants to merge
11
commits into
open-telemetry:main
from
tammy-baylis-swi:mysqlconnector-sqlcomment-v5
+472
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Does this need the |
lzchen
approved these changes
Jan 14, 2025
Good call! Added in d2c7076 |
Any other changes needed? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates mysql-connector instrumentor to support sqlcommenting. Includes support for
enable_attribute_commenter
like the other drivers.Fixes #2902
Replaces #3023
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e py312-test-instrumentation-mysql-0
instrument()
; checked MySQL server general logs after queryinstrument_connection
; checked MySQL server general logs after queryDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.