Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI - Regenerate proto files, and selective msrv-patching #2159

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Sep 30, 2024

Changes

  • Ensure msrv-patch script is selectively executed depending on the rust and crate version.
  • Regenerate proto files, for tonic/prost update.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner September 30, 2024 18:09
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (161929d) to head (618821f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2159   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        121     121           
  Lines      20933   20933           
=====================================
  Hits       16549   16549           
  Misses      4384    4384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb changed the title [WIP] Fix CI Fix CI - Regenerate proto files, and selective msrv-patching Sep 30, 2024
@lalitb
Copy link
Member Author

lalitb commented Sep 30, 2024

This should be good to review/approve now.

@lalitb lalitb closed this Sep 30, 2024
@lalitb lalitb reopened this Sep 30, 2024
@cijothomas cijothomas merged commit 6ed2b43 into open-telemetry:main Sep 30, 2024
47 checks passed
cijothomas pushed a commit to cijothomas/opentelemetry-rust that referenced this pull request Sep 30, 2024
cijothomas pushed a commit to cijothomas/opentelemetry-rust that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants