feat: configure TLS with environment variables. #2465
+516
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanz
force-pushed
the
tls-envvars
branch
3 times, most recently
from
50894e9 to
5031002
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
- Coverage 77.9% 77.4% -0.5%
=======================================
Files 123 123
Lines 22944 23168 +224
=======================================
+ Hits 17880 17948 +68
- Misses 5064 5220 +156 ☔ View full report in Codecov by Sentry. |
jvanz
force-pushed
the
tls-envvars
branch
3 times, most recently
from
9458a03 to
093a1ce
Compare
|
@TommyCpp , how can we move this forward? 😄 |
Updates the opentelemetry-otlp crate to allow users to configure TLS using environment variables. Removing the need to crating the TLS config object and defining it with the `with_tls_config` method. In the same way other OTLP libraries does (e.g. go lang). Signed-off-by: José Guilherme Vanz <[email protected]>
|
👀 Will take a look today |
TommyCpp
reviewed
Jan 21, 2025
| fn with_insecure(self) -> Self; | ||
| /// Set the certificate file to validate the OTLP server connection | ||
| /// This is only available when the `tls` feature is enabled. | ||
| fn with_certificate<T: Into<String>>(self, certificate: T) -> Self; |
There was a problem hiding this comment.
We can gate this function under #[cfg(feature = "tls")]?
Fix typo in the changelog. Signed-off-by: José Guilherme Vanz <[email protected]>
Add missing TLS configuration directives. Signed-off-by: José Guilherme Vanz <[email protected]>
ThomsonTan
reviewed
Jan 22, 2025
| @@ -36,6 +36,20 @@ pub const OTEL_EXPORTER_OTLP_METRICS_COMPRESSION: &str = "OTEL_EXPORTER_OTLP_MET | |||
| /// Example: `k1=v1,k2=v2` | |||
| /// Note: this is only supported for HTTP. | |||
| pub const OTEL_EXPORTER_OTLP_METRICS_HEADERS: &str = "OTEL_EXPORTER_OTLP_METRICS_HEADERS"; | |||
| /// | |||
| /// Certificate file to validate the OTLP server connection when sending metrics | |||
There was a problem hiding this comment.
nit: add period at the end of the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the opentelemetry-otlp crate to allow users to configure TLS using environment variables. Removing the need to crating the TLS config object and defining it with the
with_tls_configmethod. In the same way other OTLP libraries does (e.g. go lang).Partially fixes #774
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes