Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pwd for precommit.sh script to support running it in any directory #2535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ThomsonTan
Copy link
Contributor

No description provided.

@ThomsonTan ThomsonTan requested a review from a team as a code owner January 23, 2025 00:01
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (38be4d9) to head (956b7f0).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2535   +/-   ##
=====================================
  Coverage   77.7%   77.7%           
=====================================
  Files        123     123           
  Lines      23050   23050           
=====================================
  Hits       17931   17931           
  Misses      5119    5119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Jan 23, 2025

As per the Contributing.md:

Note It is recommended to run pre-commit script from the root of the repo to catch any issues locally.

@ThomsonTan
Copy link
Contributor Author

As per the Contributing.md:

Note It is recommended to run pre-commit script from the root of the repo to catch any issues locally.

Probably we can remove "from the root of the repo" in the Contributing.md? It is convenient to run it other than in the root dir.

@lalitb
Copy link
Member

lalitb commented Jan 23, 2025

Probably we can remove "from the root of the repo" in the Contributing.md? It is convenient to run it other than in the root dir.

Yes, good to do it as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants