Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move span exporter module #2540

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

cijothomas
Copy link
Member

#2534, applied to Span.

opentelemetry_sdk::export::spans::{ExportResult, SpanData, SpanExporter};
to
opentelemetry_sdk::logs::{ExportResult, SpanData, SpanExporter};

@cijothomas cijothomas requested a review from a team as a code owner January 23, 2025 02:30
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (a0e5061) to head (2d3d093).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-stdout/src/trace/exporter.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/span.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/trace/runtime_tests.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2540   +/-   ##
=====================================
  Coverage   77.7%   77.8%           
=====================================
  Files        123     123           
  Lines      23050   23047    -3     
=====================================
  Hits       17931   17931           
+ Misses      5119    5116    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 5935cca into open-telemetry:main Jan 23, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/span-export-ns branch January 23, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants