-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling the Instrument Name Validation under a new feature flag #2543
Disabling the Instrument Name Validation under a new feature flag #2543
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2543 +/- ##
=======================================
- Coverage 79.2% 79.1% -0.1%
=======================================
Files 118 118
Lines 22511 22508 -3
=======================================
- Hits 17829 17821 -8
- Misses 4682 4687 +5 ☔ View full report in Codecov by Sentry. |
…opentelemetry-rust into anujnegi/disable-name-check
Merging to unblock users. This flag is expected to be removed in near future. I am working with OTel spec to relax the validation rules. |
A fix for the feature [Feature]: A Dev Feature for Naming Convention used in Windows Performance Counters · Issue #2527 · open-telemetry/opentelemetry-rust and a related issue .
Fixes #
This fix is done under a feature flag
experimental_metrics_disable_name_validation
, where all types of instrument name are acceptable except empty names and names exceeding the length limit.Changes
Defining the validation check function under the feature flag to bypass and return Ok().
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes