Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the Instrument Name Validation under a new feature flag #2543

Merged

Conversation

anujnegi270
Copy link
Contributor

@anujnegi270 anujnegi270 commented Jan 23, 2025

A fix for the feature [Feature]: A Dev Feature for Naming Convention used in Windows Performance Counters · Issue #2527 · open-telemetry/opentelemetry-rust and a related issue .

Fixes #
This fix is done under a feature flag experimental_metrics_disable_name_validation, where all types of instrument name are acceptable except empty names and names exceeding the length limit.

Changes

Defining the validation check function under the feature flag to bypass and return Ok().

Merge requirement checklist

  • [✔️] CONTRIBUTING guidelines followed
  • [✔️] Unit tests added/updated (if applicable)
  • [✔️] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@anujnegi270 anujnegi270 requested a review from a team as a code owner January 23, 2025 23:42
Copy link

linux-foundation-easycla bot commented Jan 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@anujnegi270 anujnegi270 changed the title Disabling all type of name checks except empty names and exceeding le… Disabling the Instrument Name Validation under a new feature flag Jan 23, 2025
@anujnegi270 anujnegi270 marked this pull request as draft January 23, 2025 23:48
@anujnegi270 anujnegi270 marked this pull request as ready for review January 23, 2025 23:52
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (fdc1151) to head (d051a06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2543     +/-   ##
=======================================
- Coverage   79.2%   79.1%   -0.1%     
=======================================
  Files        118     118             
  Lines      22511   22508      -3     
=======================================
- Hits       17829   17821      -8     
- Misses      4682    4687      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

Merging to unblock users. This flag is expected to be removed in near future. I am working with OTel spec to relax the validation rules.

@cijothomas cijothomas merged commit 775f1f9 into open-telemetry:main Feb 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants