Skip to content

Commit

Permalink
Refine Dynamic Evaluation in LoggerConfig and move to Future possibil…
Browse files Browse the repository at this point in the history
…ities
  • Loading branch information
pellared committed Jan 9, 2025
1 parent e96f9e7 commit 1a9ad31
Showing 1 changed file with 14 additions and 10 deletions.
24 changes: 14 additions & 10 deletions oteps/logs/4290-logger-enabled.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,16 +181,6 @@ for different log destinations.
Below are some alternatives that would be further explored
during the Development phase.

### Dynamic Evaluation in LoggerConfig

There is a [proposal](https://github.com/open-telemetry/opentelemetry-specification/issues/4207#issuecomment-2501688210)
suggested dynamic evaluation in `LoggerConfig` instead of static configuration
to make the `LoggerConfig` to support dynamic evaluation.

However, since the purpose of `LoggerConfig` is static configuration,
and use cases (5) and (6) are tied to log record processing,
extending `LogRecordProcessor` seem more appropriate.

### Separate LogRecordFilterer Abstraction

There is a [proposal](https://github.com/open-telemetry/opentelemetry-specification/issues/4207#issuecomment-2354859647)
Expand Down Expand Up @@ -241,6 +231,20 @@ configured on the SDK level. This configuration was discussed
e.g. [here](https://github.com/open-telemetry/opentelemetry-specification/pull/4290#discussion_r1898672657)
and is beyond the scope of this OTEP.

### Dynamic Evaluation in LoggerConfig

There is a [proposal](https://github.com/open-telemetry/opentelemetry-specification/issues/4207#issuecomment-2501688210)
suggested dynamic evaluation in `LoggerConfig` instead of static configuration
to make the `LoggerConfig` to support dynamic evaluation.

However, since the purpose of `LoggerConfig` is static configuration,
and use cases (5) and (6) are tied to log record processing,
extending `LogRecordProcessor` seem more appropriate.

Additionally, nothing prevents adding some other way of configuring Loggers similar to
[Metrics View](../../specification/metrics/sdk.md#view).
This was proposed [here](https://github.com/open-telemetry/opentelemetry-specification/pull/4290#discussion_r1908897211).

### Extending Logger.Enabled

The `Enabled` API could be extended in the future
Expand Down

0 comments on commit 1a9ad31

Please sign in to comment.