-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] - clarify demo upgrade capability in Kubernetes #5655
Merged
svrnm
merged 11 commits into
open-telemetry:main
from
puckpuck:demo.k8s-upgrade-clarification
Nov 22, 2024
Merged
[demo] - clarify demo upgrade capability in Kubernetes #5655
svrnm
merged 11 commits into
open-telemetry:main
from
puckpuck:demo.k8s-upgrade-clarification
Nov 22, 2024
+43
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
reviewed
Nov 21, 2024
Co-authored-by: Juliano Costa <[email protected]>
tiffany76
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few small copyedits.
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
svrnm
approved these changes
Nov 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 22, 2024
mviitane
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the demo is started in a Kubernetes world, we use init-containers to ensure the order of services to be started (e.g., Kafka before fraud detection). However, when upgrading the demo, the order in which services are restarted can not be guaranteed. Because of this, the demo install in Kubernetes has never supported an upgrade operation, and this PR adds a note to clarify that.