pkg/otel/trace/arrow: Set parentSpanID NULL if empty bytes (#273)

Fixes #272
open-telemetry · Nov 19, 2024 · a116deb · a116deb
1 parent 817b9e4
commit a116deb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/otel/traces/arrow/traces.go b/pkg/otel/traces/arrow/traces.go
@@ -278,7 +278,11 @@ func (b *TracesBuilder) Append(traces ptrace.Traces) error {
 		b.sib.Append(sib[:])
 		b.tsb.AppendNonEmpty(span.Span.TraceState().AsRaw())
 		psib := span.Span.ParentSpanID()
-		b.psib.Append(psib[:])
+		if psib.IsEmpty() {
+			b.psib.AppendNull()
+		} else {
+			b.psib.Append(psib[:])
+		}
 		b.nb.AppendNonEmpty(span.Span.Name())
 		b.kb.AppendNonZero(int32(span.Span.Kind()))
 

diff --git a/pkg/otel/traces/otlp/traces.go b/pkg/otel/traces/otlp/traces.go
@@ -162,6 +162,10 @@ func TracesFrom(record arrow.Record, relatedData *RelatedData) (ptrace.Traces, e
 		if parentSpanID != nil && len(parentSpanID) != 8 {
 			return traces, werror.WrapWithContext(common.ErrInvalidSpanIDLength, map[string]interface{}{"parentSpanID": parentSpanID})
 		}
+		if parentSpanID == nil {
+			// parentSpanID can be null
+			parentSpanID = []byte{}
+		}
 		name, err := arrowutils.StringFromRecord(record, traceIDs.Name, row)
 		if err != nil {
 			return traces, werror.Wrap(err)