-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release script fixes #102
Merged
Merged
Release script fixes #102
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,12 +13,8 @@ WORKDIR /otel-arrow | |
COPY . . | ||
ENV CGO_ENABLED=0 | ||
|
||
# Note we recommend using the latest released builder, which will | ||
# update the core OpenTelemetry collector libraries to the newest | ||
# possible versions. When the latest set of collector dependencies | ||
# leads to a broken build here, this `latest` can instead be set | ||
# to the last-successful version of the OpenTelemetry collector. | ||
RUN go install go.opentelemetry.io/collector/cmd/builder@latest | ||
# Note the version MUST MATCH otelarrowcol-build.yaml | ||
RUN go install go.opentelemetry.io/collector/cmd/[email protected] | ||
|
||
# This command generates main.go, go.mod but does not update deps. | ||
RUN builder --skip-compilation --skip-get-modules --config=collector/otelarrowcol-build.yaml | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note not using --skip-get-modules.
The
GOWORK=off
trick works too.