Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concurrentbatchprocessor] Consistent span creation, latency, bi-directional links #241

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Sep 4, 2024

Three minor changes in CBP instrumentation:

  • unconditionally create a span, even in cases where there is a single parent; less confusing to always have a span w/ observable latency, otherwise users have to look at each receiver individually.
  • end the span after the export call, vs immediately
  • link in both directions, allows the incoming requests to link to their outgoing batch easily w/o depending on trace backend features.
    I also ran into some test debts, fixed to cover the new behavior.

@jmacd jmacd merged commit b1ae3f4 into open-telemetry:main Sep 4, 2024
2 checks passed
This was referenced Sep 5, 2024
jmacd added a commit that referenced this pull request Sep 6, 2024
- Concurrent batch processor: tracing improvements.
[#238](#238),
[#241](#241)
- Update to latest OTel-Collector & OTel-Go dependencies. Remove
collector packages now included in collector-contrib/internal/otelarrow.
[#245](#245)
- Concurrent batch processor: remove support for in-flight limits.
[#247](#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants