Add span events for admission blocked/released events #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
lquerel,
moh-osman3 and
codeboten
as code owners
moh-osman3
approved these changes
Sep 4, 2024
| @@ -85,8 +86,11 @@ func (bq *BoundedQueue) Acquire(ctx context.Context, pendingBytes int64) error { | |||
|
|
|||
| bq.lock.Unlock() | |||
|
|
|||
| trace.SpanFromContext(ctx).AddEvent("request blocked, pending bytes at limit") | |||
There was a problem hiding this comment.
Hmm why add instrumentation in this package directly instead of adding instrumentation in the calling code?
There was a problem hiding this comment.
I guess the calling code could unconditionally emit "requesting admission" and then "admission accepted" -- we would know the admission was blocked by the duration between these events. I thought that by instrumenting this package, we could limit the annotation to only the case where the request is blocked. Closed in favor of a different approach.
I've seen a span used to annotate the block
jmacd
added a commit
that referenced
this pull request
Sep 5, 2024
Alternative to #242 Allow us to monitor when requests are being blocked by admission limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a span event when a request is blocked by admission control.
(And whitespace changes: note this repo does not have
go fmtchecking, and at least one of our editors is formatting differently thango fmtdoes for me.)