fix: respect nullable settings in arrow schema #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize imports and update nullable fields in Arrow schemas - Reorder imports in components.go for clarity - Make HistogramSum, HistogramMin, and HistogramMax fields nullable in Arrow schemas for ehistogram_dp.go, histogram_dp.go, and number_data_point.go - Remove empty connector factory map initialization in components.go - Swap import order in main_windows.go for consistency
v0y4g3r
requested review from
lquerel,
jmacd,
moh-osman3 and
codeboten
as code owners
jmacd
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Looks good to me. @lquerel PTAL.
Histogram sums are optional according to the data model specification; Prometheus doesn't want them if they're not monotonic and the data model and protocol support histograms with negative values.
|
LGTM. Thanks for this fix. |
Merged
jmacd
added a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the nullable settings of fields that are actually nullable in arrow schema.