Use upstream filereceiver and fileexporter with updated docs #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still trying to resolve building locally on Windows - new to Go and Makefiles, so taking some time. Fairly certain my PR needs to include updates to |
drewrelmas
requested review from
lquerel,
jmacd,
moh-osman3 and
codeboten
as code owners
jmacd
approved these changes
Jan 17, 2025
Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originated from looking at #232 as an easy doc-related first contribution in open-telemetry organization.
In fixing 404 doc links, noted that the referenced upstream
filereceiverwas renamed tootlpjsonfilereceiver. Consulted with @jmacd and determined the best path forward is to deprecate local copies offilereceiverandfileexporterin favor of the proper, existing upstream implementations.