Attempt to release v0.7.0 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looks like it will do everything we want --
The only problem is that it won't pass CI/CD until after the release branch is pushed, which goes against the current release practice in this repo. Solution: I propose to bypass the CI/CD check using superuser powers to do so. If my hypothesis is correct, the outcome will be a successful release, and we will address this going forward with adjustments to our release process. If my hypothesis is incorrect, we will have to undo several things and go back to relative replace statements. |
|
I will close this in favor of #92, which validates the approach in this PR w/o making a release. I will re-open a new PR for the release. |
Merged
jmacd
added a commit
that referenced
this pull request
Nov 10, 2023
As with #91, this release is going to face problems with passing tests during while its new version tags are unreleased. We will bypass the automatic checks with this release, and if the results are acceptable we will address this in the future with an updated release procedure. We cannot run `go work sync` with unreleased version tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly undoes the changes in #88.
The goal was to install a go.work file, which #88 indicates does not work, and I thought I'd try again anyway.
The problem we are hoping to resolve is that a new user who can run the Golang toolchain ought to be able to run a one-line command to install the OTel Arrow collector from its module name github.com/open-telemetry/otel-arrow/collector/cmd/otelarrowcol.
This does not work because of relative
replacestatements, which breaks the one-line command functionality for Golang installation. If go.work could successfully navigate the release process for us, this would be a winning strategy, but it does not.In the present form of this PR, I removed all
replacestatements because I believe they are unnecessary. Note, however, that current OTC builders will install areplacefor cloud.google.com/go for historical reasons. With or without these replace statements (in two of the three modules here), it seems that go.work cannot survive the release process.The release process DEPENDS on having those relative replace statements, is what I'm trying to say. Is there a way for go.work to succeed in the pre-release state where
sedhas been used to update the new version in each go.mod file but the corresponding tag has not been pushed to github.com yet? This is where I'm stuck.The error is: