-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidance on product/project name inside attribute/metric name #608
Comments
With regards to representing multiple words, can a product's branding provide a guide? For example, use |
It would be nice if whatever the enum is, e.g. |
do we think we need |
SQL Server Compact runs in-process rather than as a network service, so yes, the application should know it's using that. |
Based on the messaging SIG discussion on 6/13, none of the controversial systems are part of the initial stability (kafka + RabbitMQ), so removing the stability blocker label. |
Been discussing it in the scope of #1734. There are competing consistency goals when it comes to project names. Let's explore them: 1. Stay consistent with external project/product/system/etc name whenever possibleThe guidance would be:
Non-controversial examples:
Controversial examples
2. Stay consistent within semantic conventionsThe guidance would be: Product name should be qualified with a company/division name with the following exceptions:
Non-controversial examples:
Controversial examples
Obviously wrong examples:
I personally prioritize consistency within semantic conventions higher than strict consistency with a trademark. Given that products get acquired/renamed/evolve, we won't be able to stay fully consistent. I'd prefer option 1.7 (bullets are ordered with descending priority):
There are plenty of edge-cases and we'd need to use our judgement on case-by-case basis. E.g. is informix a well-recognized product? Then is should fall under p2 and be |
this is a tough thing to decide, do you think it's possible to only use "avoid ambiguity", and so as long as it's not ambiguous (maybe relying on ownership of a common TLDs or high google SEO ranking?), we'd allow not sure how this would work with |
I'm thinking about azure.
From this perspective, I don't see a difference between IBM DB2 that can be hosted anywhere and Azure CosmosDB that's a cloud service and can run only on Azure. So if we use |
I think we can justify |
Similar justification for |
We should provide a guidance on product/project name being fully qualified (or not). We should keep the same pattern in different semconvs.
Examples of inconsistencies:
db.cosmosdb
(Azure),db.dynamodb
(AWS),db.couchdb
(under Apache umbrella),db.spanner
(GCP),db2
(IBM),hanadb
(SAP HANA) etc and corresponding values in thedb.system
enumaws_sqs
,gcp_pubsub
,azure_servicebus
in themessaging.system
enumWe should provide a guidance on how to represent multiple words:
couchdb
) (#Codegen: proper casing for multiword attribute/metric names #599)messaging.aws_sqs.destination.custom_attr
vsmessaging.aws.sqs.destination.custom_attr
)We should require consistency across signals:
db.system
andmessaging.system
cloud.platform
and/or rename it #609)Misc discrepancies:
mssqlcompact
(Microsoft SQL Server Compact) should probably becomemssql_compact
[Update]
Other attributes that have the same problem:
The text was updated successfully, but these errors were encountered: