-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent naming: db.system
to db.system.name
, namespace constants, remove db
from system-specific names
#1734
base: main
Are you sure you want to change the base?
Consistent naming: db.system
to db.system.name
, namespace constants, remove db
from system-specific names
#1734
Conversation
db.system
to db.system.name
, namespace constants, remove db
from system-specific namesdb.system
to db.system.name
, namespace constants, remove db
from system-specific names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm coming around to your proposal in #608 (comment)
bdcb0a2
to
6f9d66a
Compare
…e constants, remove db prefix from system-specific attributes
… speculative_execution.count
7574011
to
4509a9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elasticsearch part look ok to me 👍
Fix #1581
Addresses DB-related portion of #608, replaces db-related things from #1711 and #1613.
db.system
todb.system.name
. It gives us a good opportunity to clean up constants, batching multiple breaking changes together (see below)db
prefix from system-specific attributes following Add system-specific naming guidance #1708:_
->.
where it makes senseMerge requirement checklist
[chore]