Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model/profile: add frame.type for Erlang #1735

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

model/profile: add frame.type for Erlang #1735

wants to merge 3 commits into from

Conversation

florianl
Copy link
Contributor

Changes

Please provide a brief description of the changes here.

FYI @open-telemetry/profiling-maintainers

Merge requirement checklist

@florianl florianl requested review from a team as code owners January 10, 2025 10:06
@florianl florianl force-pushed the profile-frame-type-beam branch from 3c72a30 to d2d8a1b Compare January 10, 2025 10:06
@florianl florianl mentioned this pull request Jan 10, 2025
Draft
@florianl
model/profile: add frame.type for Erlang
542d56a 
Extend the list of known frame types with a value for Erlang.

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl force-pushed the profile-frame-type-beam branch from d2d8a1b to 542d56a Compare January 10, 2025 10:09
@trask
Copy link
Member

trask commented Jan 10, 2025

cc @open-telemetry/profiling-approvers

lmolkova
lmolkova approved these changes Jan 17, 2025
View reviewed changes
.chloggen/profile-frame-type-beam.yaml Outdated Show resolved Hide resolved
model/profile/registry.yaml Show resolved Hide resolved
@trask
Copy link
Member

trask commented Jan 21, 2025

moving to draft and back, to see if that will give profiling approvers green checkmark

@trask trask marked this pull request as draft January 21, 2025 01:10
@trask trask marked this pull request as ready for review January 21, 2025 01:10
@trask
Copy link
Member

trask commented Jan 21, 2025

one more try (closing and re-opening) 🤷‍♂️

@trask trask closed this Jan 21, 2025
@trask trask reopened this Jan 21, 2025
@trask
Copy link
Member

trask commented Jan 21, 2025

ah, will fix...

Unknown owner on line 114: make sure the team @open-telemetry/profiling-approvers exists, is publicly visible, and has write access to the repository
…metry/specs-semconv-approvers @open-telemetry/profiling-approvers

@lmolkova lmolkova requested a review from a team as a code owner January 23, 2025 03:05
@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2025
@lmolkova lmolkova added this to the v1.30.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christos68k christos68k christos68k approved these changes

@lmolkova lmolkova lmolkova approved these changes

@trask trask trask approved these changes

@felixge felixge felixge approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Semantic Conventions Triage
Status: Needs More Approval
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
5 participants
@florianl @trask @felixge @lmolkova @christos68k