-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify stabilization plan does not just apply to attributes #278
Clarify stabilization plan does not just apply to attributes #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
I think this is inconsistent with other wording we have elsewhere that says that semantic conventions only encompass the attribute keys and nothing else. EDIT: Found it, it's this here: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/versioning-and-stability.md#semantic-conventions-stability |
@Oberon00 I don't think that's accurate. That doc says |
Me either... it seems this section in particular is pretty exhaustive. @Oberon00 is there specific wording you're referring to that could be improved? |
You are right it encompasses quite a bit. Even though it does not encompass attribute values or types, we can have stricter requirements for this special case anyway. |
Given the good number of approvals, shall I update the rest of the files in this PR with this updated text? |
👍 |
Will review again, since now it's touching all other files
Clarification inspired by the following discussion open-telemetry/opentelemetry-dotnet#4766 (comment).
This text shows up in a lot of places. I can update them all, but wanted to get an initial review of the text here before I copy it everywhere. I assume this will not need to be updated in the specification repo once open-telemetry/opentelemetry-specification#3667 is merged.
@trask