Fix broken but supported protovalidate conformance tests #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
commented
Feb 23, 2025
| @@ -23,7 +23,7 @@ import com.google.protobuf.DescriptorProtos.FileDescriptorProto | |||
| // https://github.com/protocolbuffers/protobuf/blob/5e84a6169cf0f9716c9285c95c860bcb355dbdc1/src/google/protobuf/stubs/strutil.cc#L595 | |||
|
|
|||
| // Limit the number of bytes per line. | |||
| private const val BYTES_PER_LINE = 40 | |||
| private const val BYTES_PER_LINE = 200 | |||
There was a problem hiding this comment.
Cheapo version of #239 for now.
andrewparmet
changed the title
andrewparmet
commented
Feb 23, 2025
| assertThat(TestFileImplicit::class.propertyIsMarkedNullable("foo")).isFalse() | ||
| assertThat(TestFileImplicit {}.foo).isEqualTo(0) | ||
| assertThat(TestFileExplicit::class.propertyIsMarkedNullable("foo")).isTrue() |
There was a problem hiding this comment.
This test was broken due to bad copypasta of the message type being asserted on.
ogolberg
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining failing tests are for fields with
features.message_encoding = DELIMITED, which the docs note:which we don't support.