Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

IOS: Subscription update with replacing stream #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kirankumar-ravuri
Copy link
Contributor

Added passing streamid to the sdk for updating subscription

Copy link
Collaborator

@jianjunz jianjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. But I'm not merging this PR at this time because this is a non-trivial feature enhancement. APIs need to be detailed designed. For example, server side allows to replace audio/video track only.

@JamesTerm
Copy link

@jianjunz I see this PR is delayed merging, and so I ask... what is a preferred way to discuss contributions (features) to determine beforehand if they are PR candidate vs. ones that are not... I will have some soon, but I wish to discuss them to see if they are PR candidates first... and for that matter which ones are candidates for 4.2 release. I only wish to do PR's if I know this is what we want for everyone.

@jianjunz
Copy link
Collaborator

jianjunz commented Jul 6, 2019

Hi @JamesTerm, sorry for my late reply. IMHO, I'd prefer to open an issue before a large feature, so we can discuss its design and schedule, especially for those involves both client and server side changes. Perhaps we could create a new repository to track these feature requests. For some small changes, I think it's OK to just create a PR.
Other members may have their own opinions about the process for contributing a new feature.

@JamesTerm
Copy link

Thanks for reply I've created issue #141, as it is a large feature

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants