Deduplication reporting update #187
Open
+94
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phlya
reviewed
Oct 18, 2023
| is_flag=True, | ||
| default=False, | ||
| help="Add column to the output pairs with the number of duplicates. " | ||
| "Comparible with sklearn and scipy backends only. " |
Phlya
reviewed
Oct 18, 2023
| default=False, | ||
| help="Add column to the output pairs with the number of duplicates. " | ||
| "Comparible with sklearn and scipy backends only. " | ||
| "Is not counted by default. [output dedup pairs format option]", |
Phlya
reviewed
Oct 18, 2023
| @@ -388,6 +398,11 @@ def dedup_py( | |||
| send_header_to_dedup = send_header_to in ["both", "dedup"] | |||
| send_header_to_dup = send_header_to in ["both", "dups"] | |||
|
|
|||
| count_dups = kwargs.get("count_dups", False) | |||
| if backend=="cython" and count_dups: | |||
| logger.warning("Not countin number of duplicates with Cython backend.") | |||
|
Can you add tests for this feature? |
golobor
reviewed
Mar 9, 2024
| @@ -221,8 +279,16 @@ def _dedup_chunk( | |||
| df = df.reset_index() # Remove the index temporarily | |||
|
|
|||
| # Set up columns to store the dedup info: | |||
| df["clusterid"] = np.nan | |||
| df["duplicate"] = False | |||
| df.loc[:, "clusterid"] = np.nan | |||
There was a problem hiding this comment.
@agalitsyna , tests fail at this line with an error message "ValueError: cannot set a frame with no defined index and a scalar".
Googling suggests that such an error arises when one tried to index an empty frame: https://stackoverflow.com/questions/48306694/valueerror-cannot-set-a-frame-with-no-defined-index-and-a-value-that-cannot-be
There was a problem hiding this comment.
Maybe df.assign? What's your favorite way of filling in columns in dataframe?
https://stackoverflow.com/questions/34811971/how-do-i-fill-a-column-with-one-value-in-pandas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--count-dupsreporting mode for scipy and scikit-learn backends that report the number of duplicates (a little bit unfair, though, as the parent is counted there as well - it seems to make most of sense to report).