Feat: Migrate :core:designsystem to KMP #2290
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
requested changes
Jan 20, 2025
biplab1
changed the title
biplab1
commented
Jan 23, 2025
| @@ -23,6 +21,7 @@ import androidx.compose.ui.geometry.Offset | |||
| import androidx.compose.ui.graphics.Color | |||
| import androidx.compose.ui.graphics.drawscope.Stroke | |||
| import androidx.compose.ui.input.pointer.pointerInteropFilter | |||
There was a problem hiding this comment.
I couldn't resolve the pointerInteropFilter and android.view.MotionEvent issue.
biplab1
commented
Jan 23, 2025
| import com.mifos.core.designsystem.theme.DarkGray | ||
| import org.jetbrains.compose.resources.stringResource | ||
| import androidclient.core.designsystem.generated.resources.Res | ||
| import androidclient.core.designsystem.generated.resources.core_designsystem_ic_error_black_24dp |
There was a problem hiding this comment.
I am not satisfied with this resolution of adding the string resources, it temporary resolves the issue, however, I don't think it is an optimized approach.
biplab1
commented
Jan 23, 2025
| */ | ||
| package com.mifos.core.designsystem.theme | ||
|
|
||
| import androidclient.core.designsystem.generated.resources.Res |
There was a problem hiding this comment.
Here I tried using android_client instead of androidclient, however, the generated resources in build folder has package named androidclient and not android_client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#I334
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.