feat(feature:savings-account): Migrate savings-account module to CMP #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HekmatullahAmin
commented
Feb 17, 2025
...unt/src/commonMain/kotlin/org/mifos/mobile/feature/savingsaccount/screen/utils/FilterUtil.kt
Outdated
Show resolved
Hide resolved
niyajali
requested changes
Feb 17, 2025
...n/kotlin/org/mifos/mobile/feature/savingsaccount/screen/viewmodel/SavingsAccountViewmodel.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/org/mifos/mobile/feature/savingsaccount/screen/component/AccountCard.kt
Outdated
Show resolved
Hide resolved
HekmatullahAmin
changed the title
HekmatullahAmin
force-pushed
the
MM-182
branch
from
2b115ed to
4a27502
Compare
niyajali
requested changes
Feb 19, 2025
...src/commonMain/kotlin/org/mifos/mobile/feature/savingsaccount/screen/SavingsAccountScreen.kt
Outdated
Show resolved
Hide resolved
...src/commonMain/kotlin/org/mifos/mobile/feature/savingsaccount/screen/SavingsAccountScreen.kt
Outdated
Show resolved
Hide resolved
...monMain/kotlin/org/mifos/mobile/feature/savingsaccount/screen/SavingsAccountScreenContent.kt
Outdated
Show resolved
Hide resolved
niyajali
previously requested changes
Feb 19, 2025
...src/commonMain/kotlin/org/mifos/mobile/feature/savingsaccount/screen/SavingsAccountScreen.kt
Outdated
Show resolved
Hide resolved
…el and Screen - Created `SavingsAccountViewModel` with functions for search, filter, and account loading - Implemented `SavingsAccountScreen` - Refactored function names for clarity and consistency: - `searchInSavingsList` → `filterAccountsBySearchQuery` - `getFilterSavingsAccountList` → `filterAccountsByStatus` - `getFilteredSavingsAccount` → `getAccountsMatchingStatus` - Improved composable readability by extracting helper functions: - `getAccountStatusDisplayAttributes`
HekmatullahAmin
force-pushed
the
MM-182
branch
from
4a27502 to
995562b
Compare
|
Hi Mr. @therajanmaurya , @niyajali I hope you’re doing well. I’ve applied the suggestions:
Could you please review these updates? Kindly approve and merge at your convenience. |
therajanmaurya
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#182
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.